Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-perf-hooks-histogram #43567

Merged
merged 1 commit into from
Jul 4, 2022
Merged

test: fix flaky test-perf-hooks-histogram #43567

merged 1 commit into from
Jul 4, 2022

Conversation

santigimeno
Copy link
Member

Make sure the histogram containing event loop delay info is posted only
when at least one datapoint is collected.

Fixes: #43503

@santigimeno
test: fix flaky test-perf-hooks-histogram
f62f7bf 
Make sure the histogram containing event loop delay info is posted only
when at least one datapoint is collected.

Fixes: nodejs#43503
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 25, 2022
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 25, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 25, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44854/

This was referenced Jun 26, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44890/

@F3n67u F3n67u added request-ci Add this label to start a Jenkins CI on a PR. needs-ci PRs that need a full CI run. and removed needs-ci PRs that need a full CI run. labels Jun 28, 2022
@github-actions github-actions bot mentioned this pull request Jun 28, 2022
Open
32 tasks
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44919/

@github-actions github-actions bot mentioned this pull request Jun 29, 2022
Open
23 tasks
@F3n67u F3n67u mentioned this pull request Jun 29, 2022
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45073/

@github-actions github-actions bot mentioned this pull request Jul 4, 2022
Open
23 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45077/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 4, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 4, 2022
@nodejs-github-bot nodejs-github-bot merged commit fd1e39f into nodejs:main Jul 4, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in fd1e39f

@github-actions github-actions bot mentioned this pull request Jul 8, 2022
Open
16 tasks
targos pushed a commit that referenced this pull request Jul 12, 2022
@santigimeno @targos
test: fix flaky test-perf-hooks-histogram
2adf4e7 
Make sure the histogram containing event loop delay info is posted only
when at least one datapoint is collected.

Fixes: #43503

PR-URL: #43567
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@santigimeno @targos
test: fix flaky test-perf-hooks-histogram
bfcd7f0 
Make sure the histogram containing event loop delay info is posted only
when at least one datapoint is collected.

Fixes: #43503

PR-URL: #43567
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@santigimeno @targos
test: fix flaky test-perf-hooks-histogram
9bc4ad0 
Make sure the histogram containing event loop delay info is posted only
when at least one datapoint is collected.

Fixes: #43503

PR-URL: #43567
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@santigimeno @guangwong
test: fix flaky test-perf-hooks-histogram
579fae8 
Make sure the histogram containing event loop delay info is posted only
when at least one datapoint is collected.

Fixes: nodejs/node#43503

PR-URL: nodejs/node#43567
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky test-perf-hooks-histogram
5 participants
@santigimeno @nodejs-github-bot @jasnell @lpinca @F3n67u